Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
flask-admin
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
JIRA
JIRA
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Python-Dev
flask-admin
Commits
085c6e77
Commit
085c6e77
authored
Apr 28, 2013
by
Mostafa Rokooie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix ObjectId casting bug in get_one and delete_action
parent
d6cd59d0
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
11 additions
and
3 deletions
+11
-3
view.py
flask_admin/contrib/pymongo/view.py
+11
-3
No files found.
flask_admin/contrib/pymongo/view.py
View file @
085c6e77
import
logging
import
pymongo
from
bson
import
ObjectId
from
bson.errors
import
InvalidId
from
flask
import
flash
from
jinja2
import
contextfunction
...
...
@@ -241,6 +243,13 @@ class ModelView(BaseModelView):
return
count
,
results
def
_get_valid_id
(
self
,
id
):
try
:
return
ObjectId
(
id
)
except
InvalidId
:
return
id
def
get_one
(
self
,
id
):
"""
Return single model instance by ID
...
...
@@ -248,8 +257,7 @@ class ModelView(BaseModelView):
:param id:
Model ID
"""
# TODO: Validate if it is valid ID
return
self
.
coll
.
find_one
({
'_id'
:
id
})
return
self
.
coll
.
find_one
({
'_id'
:
self
.
_get_valid_id
(
id
)})
def
edit_form
(
self
,
obj
):
"""
...
...
@@ -336,7 +344,7 @@ class ModelView(BaseModelView):
# TODO: Optimize me
for
pk
in
ids
:
self
.
coll
.
remove
({
'_id'
:
pk
})
self
.
coll
.
remove
({
'_id'
:
self
.
_get_valid_id
(
pk
)
})
count
+=
1
flash
(
ngettext
(
'Model was successfully deleted.'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment