Unverified Commit 7fa26ab2 authored by Serge S. Koval's avatar Serge S. Koval Committed by GitHub

Merge pull request #826 from redpandalabs/patch-1

swallow TypeError only if related to compatibility
parents ee59ae51 e809d0d9
...@@ -1546,12 +1546,15 @@ class BaseModelView(BaseView, ActionsMixin): ...@@ -1546,12 +1546,15 @@ class BaseModelView(BaseView, ActionsMixin):
""" """
try: try:
self.on_model_change(form, model, is_created) self.on_model_change(form, model, is_created)
except TypeError: except TypeError as e:
if re.match(r'on_model_change\(\) takes .* 3 .* arguments .* 4 .* given .*', e.message):
msg = ('%s.on_model_change() now accepts third ' + msg = ('%s.on_model_change() now accepts third ' +
'parameter is_created. Please update your code') % self.model 'parameter is_created. Please update your code') % self.model
warnings.warn(msg) warnings.warn(msg)
self.on_model_change(form, model) self.on_model_change(form, model)
else:
raise
def after_model_change(self, form, model, is_created): def after_model_change(self, form, model, is_created):
""" """
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment