Commit bc291172 authored by Bryan Hoyt's avatar Bryan Hoyt

Update tests to work with new filters_by_group dict format

parent 26b12141
...@@ -992,7 +992,7 @@ class BaseModelView(BaseView, ActionsMixin): ...@@ -992,7 +992,7 @@ class BaseModelView(BaseView, ActionsMixin):
if self.named_filter_urls: if self.named_filter_urls:
return u'{name}_{operation}'.format(name=flt.name, operation=flt.operation()).lower().replace(' ', '_') return u'{name}_{operation}'.format(name=flt.name, operation=flt.operation()).lower().replace(' ', '_')
else: else:
return unicode(self._filters.index(flt)) return str(self._filters.index(flt))
def get_filter_args(self): def get_filter_args(self):
""" """
......
...@@ -233,61 +233,52 @@ def test_column_filters(): ...@@ -233,61 +233,52 @@ def test_column_filters():
eq_(len(view._filters), 4) eq_(len(view._filters), 4)
eq_(view._filter_dict, { eq_([ (f['label'], f['operation']) for f in view._flattened_filters_by_group['Test1'] ],
u'Test1': [ [('0', u'equals')
(0, u'equals'), ('1', u'not equal')
(1, u'not equal'), ('2', u'contains')
(2, u'contains'), ('3', u'not contains')])
(3, u'not contains')
]})
# Test filter that references property # Test filter that references property
view = CustomModelView(Model2, db.session, view = CustomModelView(Model2, db.session,
column_filters=['model1']) column_filters=['model1'])
eq_(view._filter_dict, {
u'Model1 / Test1': [ eq_([ (f['label'], f['operation']) for f in view._flattened_filters_by_group['Model1 / Test1'] ],
(0, u'equals'), [('0', u'equals')
(1, u'not equal'), ('1', u'not equal')
(2, u'contains'), ('2', u'contains')
(3, u'not contains') ('3', u'not contains')])
], eq_([ (f['label'], f['operation']) for f in view._flattened_filters_by_group['Model1 / Test2'] ],
'Model1 / Test2': [ [('4', u'equals')
(4, 'equals'), ('5', u'not equal')
(5, 'not equal'), ('6', u'contains')
(6, 'contains'), ('7', u'not contains')])
(7, 'not contains') eq_([ (f['label'], f['operation']) for f in view._flattened_filters_by_group['Model1 / Test3'] ],
], [('8', u'equals')
u'Model1 / Test3': [ ('9', u'not equal')
(8, u'equals'), ('10', u'contains')
(9, u'not equal'), ('11', u'not contains')])
(10, u'contains'), eq_([ (f['label'], f['operation']) for f in view._flattened_filters_by_group['Model1 / Test4'] ],
(11, u'not contains') [('12', u'equals')
], ('13', u'not equal')
u'Model1 / Test4': [ ('14', u'contains')
(12, u'equals'), ('15', u'not contains')])
(13, u'not equal'), eq_([ (f['label'], f['operation']) for f in view._flattened_filters_by_group['Model1 / Bool Field'] ],
(14, u'contains'), [('16', u'equals')
(15, u'not contains') ('17', u'not equal')])
], eq_([ (f['label'], f['operation']) for f in view._flattened_filters_by_group['Model1 / Enum Field'] ],
u'Model1 / Bool Field': [ [('18', u'equals')
(16, u'equals'), ('19', u'not equal')])
(17, u'not equal'),
],
u'Model1 / Enum Field': [
(18, u'equals'),
(19, u'not equal'),
]})
# Test filter with a dot # Test filter with a dot
view = CustomModelView(Model2, db.session, view = CustomModelView(Model2, db.session,
column_filters=['model1.bool_field']) column_filters=['model1.bool_field'])
eq_(view._filter_dict, { eq_([ (f['label'], f['operation']) for f in view._flattened_filters_by_group['Model1 / Bool Field'] ],
'Model1 / Bool Field': [ [('0', u'equals')
(0, 'equals'), ('1', u'not equal')])
(1, 'not equal'),
]})
# Fill DB # Fill DB
model1_obj1 = Model1('model1_obj1', bool_field=True) model1_obj1 = Model1('model1_obj1', bool_field=True)
...@@ -324,9 +315,11 @@ def test_column_filters(): ...@@ -324,9 +315,11 @@ def test_column_filters():
column_filters=['int_field']) column_filters=['int_field'])
admin.add_view(view) admin.add_view(view)
eq_(view._filter_dict, {'Int Field': [(0, 'equals'), (1, 'not equal'), eq_([ (f['label'], f['operation']) for f in view._flattened_filters_by_group['Int Field'] ],
(2, 'greater than'), (3, 'smaller than')]}) [('0', u'equals')
('1', u'not equal')
('2', u'greater than')
('3', u'smaller than')])
#Test filters to joined table field #Test filters to joined table field
view = CustomModelView( view = CustomModelView(
......
...@@ -302,8 +302,8 @@ def test_column_filters(): ...@@ -302,8 +302,8 @@ def test_column_filters():
eq_(view._filters[0].name, 'col1') eq_(view._filters[0].name, 'col1')
eq_(view._filters[1].name, 'col2') eq_(view._filters[1].name, 'col2')
eq_(view._filter_dict, {'col1': [(0, 'test')], eq_([ (f['label'], f['operation']) for f in view._flattened_filters_by_group['col1'] ], [('0', 'test')])
'col2': [(1, 'test')]}) eq_([ (f['label'], f['operation']) for f in view._flattened_filters_by_group['col2'] ], [('1', 'test')])
# TODO: Make calls with filters # TODO: Make calls with filters
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment