Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
H
heroku-buildpack-nodejs
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
JIRA
JIRA
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Python-Dev
heroku-buildpack-nodejs
Commits
6d2a9b47
Commit
6d2a9b47
authored
Sep 06, 2017
by
Hunter Loftis
Committed by
GitHub
Sep 06, 2017
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #469 from heroku/manual-yarn-version
manual default for yarn version
parents
940c813d
8c9a3110
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
8 deletions
+9
-8
binaries.sh
lib/binaries.sh
+2
-2
run
test/run
+7
-6
No files found.
lib/binaries.sh
View file @
6d2a9b47
...
...
@@ -9,11 +9,11 @@ needs_resolution() {
install_yarn
()
{
local dir
=
"
$1
"
local
version
=
"
$2
"
local
version
=
${
2
:-
0
.28.4
}
local
number
local
url
echo
"Resolving yarn version
$
{
version
:-
(latest)
}
..."
echo
"Resolving yarn version
$
version
..."
if
!
read
number url < <
(
curl
--silent
--get
--retry
5
--retry-max-time
15
--data-urlencode
"range=
$version
"
"https://nodebin.herokai.com/v1/yarn/
$platform
/latest.txt"
)
;
then
fail_bin_install yarn
$version
;
fi
...
...
test/run
View file @
6d2a9b47
#!/usr/bin/env bash
# See README.md for info on running these tests.
# TODO: check this test on heroku-16
# testBowerAngularResolution() {
# compile "bower-angular-resolution"
# assertCaptured "Bower may need a resolution hint for angular"
# assertCapturedError
#}
testNoVersion
()
{
compile
"no-version"
assertCaptured
"engines.node (package.json): unspecified"
...
...
@@ -288,12 +295,6 @@ testMultipleRuns() {
assertCapturedSuccess
}
testBowerAngularResolution
()
{
compile
"bower-angular-resolution"
assertCaptured
"Bower may need a resolution hint for angular"
assertCapturedError
}
testUntrackedDependencies
()
{
compile
"missing-grunt"
assertCaptured
"Grunt may not be tracked in package.json"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment