Bump default version of Node to Node 8

9321b6c6 · Jeremy Morrell · Jeremy Morrell · 925038bb · 9321b6c6 · 9321b6c6
Commit 9321b6c6 authored Nov 13, 2017 by Jeremy Morrell Committed by Jeremy Morrell Nov 13, 2017
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 3 deletions

binaries.sh lib/binaries.sh +1 -1

package.json test/fixtures/unmet-dep/package.json +3 -0

run test/run +2 -2

No files found.
--- a/lib/binaries.sh
+++ b/lib/binaries.sh
@@ -27,7 +27,7 @@ install_yarn() {
 }
 install_nodejs() {
-  local version=${1:-6.x}
+  local version=${1:-8.x}
  local dir="$2"
  echo "Resolving node version $version..."

--- a/test/fixtures/unmet-dep/package.json
+++ b/test/fixtures/unmet-dep/package.json
@@ -3,6 +3,9 @@
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
+  "engines": {
+    "node": "6.x"
+  },
  "scripts": {
    "start": "node server.js"
  },

--- a/test/run
+++ b/test/run
@@ -11,8 +11,8 @@
 testNoVersion() {
  compile "no-version"
  assertCaptured "engines.node (package.json):  unspecified"
-  assertCaptured "Resolving node version 6.x"
+  assertCaptured "Resolving node version 8.x"
-  assertCaptured "Downloading and installing node 6."
+  assertCaptured "Downloading and installing node 8."
  assertCapturedSuccess
 }