Commit dc9b68f8 authored by Ed Morley's avatar Ed Morley Committed by Jeremy Morrell

Differentiate between an empty cache and a new signature

Previously new apps (or apps where the cache has been cleared using
the heroku-repo plugin) would give a skipping cache restore message
of "new-signature" which was slightly misleading.
parent da19bdb7
...@@ -2,6 +2,8 @@ ...@@ -2,6 +2,8 @@
## Master ## Master
- Log output now differentiates between an empty cache and a new cache signature
## v106 (2017-06-19) ## v106 (2017-06-19)
- Default to npm v5 if `package-lock.json` is present (#429) - Default to npm v5 if `package-lock.json` is present (#429)
......
...@@ -19,6 +19,8 @@ load_signature() { ...@@ -19,6 +19,8 @@ load_signature() {
get_cache_status() { get_cache_status() {
if ! ${NODE_MODULES_CACHE:-true}; then if ! ${NODE_MODULES_CACHE:-true}; then
echo "disabled" echo "disabled"
elif ! test -d "${CACHE_DIR}/node/"; then
echo "not-found"
elif [ "$(create_signature)" != "$(load_signature)" ]; then elif [ "$(create_signature)" != "$(load_signature)" ]; then
echo "new-signature" echo "new-signature"
else else
......
...@@ -54,7 +54,7 @@ testBuildWithCache() { ...@@ -54,7 +54,7 @@ testBuildWithCache() {
cache=$(mktmpdir) cache=$(mktmpdir)
compile "stable-node" $cache compile "stable-node" $cache
assertCaptured "Skipping cache restore (new-signature" assertCaptured "Skipping cache restore (not-found)"
assertEquals "1" "$(ls -1 $cache/node/node_modules | grep hashish | wc -l | tr -d ' ')" assertEquals "1" "$(ls -1 $cache/node/node_modules | grep hashish | wc -l | tr -d ' ')"
assertCapturedSuccess assertCapturedSuccess
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment