Add rest of non-test bash to shellcheck (#610)

* Add rest of non-test bash to shellcheck

ci-profile/nodejs.sh

+#!/usr/bin/env bash
+
 export PATH="$HOME/.heroku/node/bin:$HOME/.heroku/yarn/bin:$PATH:$HOME/bin:$HOME/node_modules/.bin"
 export NODE_HOME="$HOME/.heroku/node"
 export NODE_ENV=${NODE_ENV:-test}

etc/ci-setup.sh

@@ -2,7 +2,7 @@
 
 [ "$CI" != "true" ] && echo "Not running on CI!" && exit 1
 
-git config --global user.email ${HEROKU_API_USER:-"buildpack@example.com"}
+git config --global user.email "${HEROKU_API_USER:-"buildpack@example.com"}"
 git config --global user.name 'BuildpackTester'
 
 cat <<EOF >> ~/.ssh/config

etc/hatchet.sh

@@ -26,14 +26,16 @@ if [ -z "$HEROKU_API_KEY" ]; then
 fi
 
 if [ -n "$CIRCLE_BRANCH" ]; then
-  export HATCHET_BUILDPACK_BRANCH="$CIRCLE_BRANCH"
+  HATCHET_BUILDPACK_BRANCH="$CIRCLE_BRANCH"
 elif [ -n "$TRAVIS_PULL_REQUEST_BRANCH" ]; then
   export IS_RUNNING_ON_TRAVIS=true
-  export HATCHET_BUILDPACK_BRANCH="$TRAVIS_PULL_REQUEST_BRANCH"
+  HATCHET_BUILDPACK_BRANCH="$TRAVIS_PULL_REQUEST_BRANCH"
 else
-  export HATCHET_BUILDPACK_BRANCH=$(git name-rev HEAD 2> /dev/null | sed 's#HEAD\ \(.*\)#\1#' | sed 's#tags\/##')
+  HATCHET_BUILDPACK_BRANCH=$(git name-rev HEAD 2> /dev/null | sed 's#HEAD\ \(.*\)#\1#' | sed 's#tags\/##')
 fi
 
+export HATCHET_BUILDPACK_BRANCH
+
 gem install bundler
 bundle install
 

etc/publish.sh

@@ -7,7 +7,7 @@ BP_NAME=${1:-"heroku/nodejs"}
 curVersion=$(heroku buildpacks:versions "$BP_NAME" | awk 'FNR == 3 { print $1 }')
 newVersion="v$((curVersion + 1))"
 
-read -p "Deploy as version: $newVersion [y/n]? " choice
+read -r -p "Deploy as version: $newVersion [y/n]? " choice
 case "$choice" in
   y|Y ) echo "";;
   n|N ) exit 0;;

makefile

@@ -3,8 +3,8 @@ test: heroku-18 heroku-16 cedar-14
 shellcheck:
 	@shellcheck -x bin/compile bin/detect bin/release bin/test bin/test-compile
 	@shellcheck -x lib/**
-	@echo TODO shellcheck -x ci-profile/**/*.sh
-	@echo TODO shellcheck -x etc/**/*.sh
+	@shellcheck -x ci-profile/**
+	@shellcheck -x etc/**
 
 heroku-18:
 	@echo "Running tests in docker (heroku-18)..."