Commit f6062e5c authored by Zeke Sikelianos's avatar Zeke Sikelianos

Merge pull request #77 from heroku/node-env-production

Set default NODE_ENV to 'production'. Can't sit on the fence forever with this implementation.
parents e7a4fff9 ae619742
...@@ -98,7 +98,8 @@ fi ...@@ -98,7 +98,8 @@ fi
# Update the PATH # Update the PATH
status "Building runtime environment" status "Building runtime environment"
mkdir -p $build_dir/.profile.d mkdir -p $build_dir/.profile.d
echo "export PATH=\"\$HOME/vendor/node/bin:\$HOME/bin:\$HOME/node_modules/.bin:\$PATH\"" > $build_dir/.profile.d/nodejs.sh echo "export PATH=\"\$HOME/vendor/node/bin:\$HOME/bin:\$HOME/node_modules/.bin:\$PATH\";\
export NODE_ENV=${NODE_ENV:-production}" > $build_dir/.profile.d/nodejs.sh
# Post package.json to nomnom service # Post package.json to nomnom service
# Use a subshell so failures won't break the build. # Use a subshell so failures won't break the build.
......
...@@ -60,7 +60,7 @@ testUnstableVersion() { ...@@ -60,7 +60,7 @@ testUnstableVersion() {
testProfileCreated() { testProfileCreated() {
compile "stable-node" compile "stable-node"
assertCaptured "Building runtime environment" assertCaptured "Building runtime environment"
assertFile "export PATH=\"\$HOME/vendor/node/bin:\$HOME/bin:\$HOME/node_modules/.bin:\$PATH\"" ".profile.d/nodejs.sh" assertFile "export PATH=\"\$HOME/vendor/node/bin:\$HOME/bin:\$HOME/node_modules/.bin:\$PATH\";export NODE_ENV=${NODE_ENV:-production}" ".profile.d/nodejs.sh"
assertCapturedSuccess assertCapturedSuccess
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment