Commit dcc9dd6d authored by Serge S. Koval's avatar Serge S. Koval

Merge pull request #1002 from pawl/fix_xss_2

fix xss vulnerability - escape html in column_editable_list values
parents a00b716a f447db0c
from flask import json from flask import json
from jinja2 import escape
from wtforms.widgets import HTMLString, html_params from wtforms.widgets import HTMLString, html_params
from flask_admin._compat import as_unicode from flask_admin._compat import as_unicode
...@@ -92,7 +93,8 @@ class XEditableWidget(object): ...@@ -92,7 +93,8 @@ class XEditableWidget(object):
kwargs = self.get_kwargs(subfield, kwargs) kwargs = self.get_kwargs(subfield, kwargs)
return HTMLString( return HTMLString(
'<a %s>%s</a>' % (html_params(**kwargs), kwargs['data-value']) '<a %s>%s</a>' % (html_params(**kwargs),
escape(kwargs['data-value']))
) )
def get_kwargs(self, subfield, kwargs): def get_kwargs(self, subfield, kwargs):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment