Commit deef2625 authored by PJ Janse van Rensburg's avatar PJ Janse van Rensburg

Separate 'search' substring from rest of placeholder text.

parent 95d4d102
...@@ -592,10 +592,10 @@ class ModelView(BaseModelView): ...@@ -592,10 +592,10 @@ class ModelView(BaseModelView):
column_labels = dict(name='Name', last_name='Last Name') column_labels = dict(name='Name', last_name='Last Name')
column_searchable_list = ('name', 'last_name') column_searchable_list = ('name', 'last_name')
placeholder is: "Search: Name, Last Name" placeholder is: "Name, Last Name"
""" """
if not self.column_searchable_list: if not self.column_searchable_list:
return 'Search' return None
placeholders = [] placeholders = []
...@@ -607,7 +607,7 @@ class ModelView(BaseModelView): ...@@ -607,7 +607,7 @@ class ModelView(BaseModelView):
placeholders.append( placeholders.append(
self.column_labels.get(searchable, searchable)) self.column_labels.get(searchable, searchable))
return 'Search: %s' % u', '.join(placeholders) return u', '.join(placeholders)
def scaffold_filters(self, name): def scaffold_filters(self, name):
""" """
......
...@@ -1109,9 +1109,9 @@ class BaseModelView(BaseView, ActionsMixin): ...@@ -1109,9 +1109,9 @@ class BaseModelView(BaseView, ActionsMixin):
def search_placeholder(self): def search_placeholder(self):
""" """
Return search placeholder. Return search placeholder text.
""" """
return 'Search' return None
# Filter helpers # Filter helpers
def scaffold_filters(self, name): def scaffold_filters(self, name):
......
...@@ -74,14 +74,14 @@ ...@@ -74,14 +74,14 @@
{% endif %} {% endif %}
{% if search %} {% if search %}
<div class="input-append"> <div class="input-append">
<input type="text" name="search" value="{{ search }}" class="{{ input_class }}" placeholder="{{ _gettext('%(placeholder)s', placeholder=search_placeholder) }}"> <input type="text" name="search" value="{{ search }}" class="{{ input_class }}" placeholder="{{ _gettext('Search') }}{% if search_placeholder %}: {{ search_placeholder }}{% endif %}">
<a href="{{ clear_search_url }}" class="clear add-on"> <a href="{{ clear_search_url }}" class="clear add-on">
<i class="fa fa-times icon-remove"></i> <i class="fa fa-times icon-remove"></i>
</a> </a>
</div> </div>
{% else %} {% else %}
<div> <div>
<input type="text" name="search" value="" class="{{ input_class }}" placeholder="{{ _gettext('%(placeholder)s', placeholder=search_placeholder) }}"> <input type="text" name="search" value="" class="{{ input_class }}" placeholder="{{ _gettext('Search') }}{% if search_placeholder %}: {{ search_placeholder }}{% endif %}">
</div> </div>
{% endif %} {% endif %}
</form> </form>
......
...@@ -58,7 +58,7 @@ ...@@ -58,7 +58,7 @@
<div class="clearfix"></div> <div class="clearfix"></div>
{% endmacro %} {% endmacro %}
{% macro search_form(input_class="col-md-2") %} {% macro search_form(input_class="col-md-5") %}
<form method="GET" action="{{ return_url }}" class="navbar-form navbar-left" role="search"> <form method="GET" action="{{ return_url }}" class="navbar-form navbar-left" role="search">
{% for flt_name, flt_value in filter_args.items() %} {% for flt_name, flt_value in filter_args.items() %}
<input type="hidden" name="{{ flt_name }}" value="{{ flt_value }}"> <input type="hidden" name="{{ flt_name }}" value="{{ flt_value }}">
...@@ -74,12 +74,12 @@ ...@@ -74,12 +74,12 @@
{% endif %} {% endif %}
{% if search %} {% if search %}
<div class="input-group"> <div class="input-group">
<input type="text" name="search" value="{{ search }}" class="{{ input_class }} form-control" placeholder="{{ _gettext('%(placeholder)s', placeholder=search_placeholder) }}"> <input type="text" name="search" value="{{ search }}" class="{{ input_class }} form-control" placeholder="{{ _gettext('Search') }}{% if search_placeholder %}: {{ search_placeholder }}{% endif %}">
<a href="{{ clear_search_url }}" class="input-group-addon clear"><span class="fa fa-times glyphicon glyphicon-remove"></span></a> <a href="{{ clear_search_url }}" class="input-group-addon clear"><span class="fa fa-times glyphicon glyphicon-remove"></span></a>
</div> </div>
{% else %} {% else %}
<div class="form-group"> <div class="form-group">
<input type="text" name="search" value="" class="{{ input_class }} form-control" placeholder="{{ _gettext('%(placeholder)s', placeholder=search_placeholder) }}"> <input type="text" name="search" value="" class="{{ input_class }} form-control" placeholder="{{ _gettext('Search') }}{% if search_placeholder %}: {{ search_placeholder }}{% endif %}">
</div> </div>
{% endif %} {% endif %}
</form> </form>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment