• Sergey Markelov's avatar
    A proposal to fix https://github.com/mrjoes/flask-admin/issues/532 · eddc1e17
    Sergey Markelov authored
    From the issue:
    
    If an image extension is 'jpeg' (not 'jpg'), then inside
    ImageUploadField._save_file() the call to self._get_save_format() enters
    the if-statement where the filename is changed to ${name}.jpg. The
    format stays unchanged, though, because it's the same 'JPEG'. As a
    result, the original filename is preserved on disk, which is
    ${name}.jpeg, but _save_file() returns ${name}.jpg.
    
    self._save_thumbnail(data, filename, format) saves the thumbnail file
    under ${name}_thumb.jpg
    
    At the time when ImageUploadField._save_file() is finished, two files
    are created:
    
    ${name}.jpeg
    ${name}_thumb.jpg
    Would you consider changing
    
    def _save_file(self, data, filename):
    ...
    data.save(path)
    
    to
    data.save( self._get_path(filename) )
    
    In that case the original image will be saved with the updated filename
    after self._get_save_format(filename, self.image)
    eddc1e17
Name
Last commit
Last update
..
contrib Loading commit data...
form Loading commit data...
model Loading commit data...
static Loading commit data...
templates Loading commit data...
tests Loading commit data...
translations Loading commit data...
__init__.py Loading commit data...
_backwards.py Loading commit data...
_compat.py Loading commit data...
actions.py Loading commit data...
babel.py Loading commit data...
base.py Loading commit data...
helpers.py Loading commit data...
menu.py Loading commit data...
tools.py Loading commit data...