Commit 396ed485 authored by zeke's avatar zeke

handle semver ranges that contain spaces

parent cfeefc25
......@@ -19,8 +19,7 @@ trap cat_npm_debug_log ERR
semver_range=$(cat $build_dir/package.json | $bp_dir/vendor/jq -r .engines.node)
# Resolve node version using semver.io
semver_url=http://semver.io/node/resolve/$semver_range
node_version=$(curl --silent $semver_url)
node_version=$(curl --silent --get --data-urlencode "range=${semver_range}" http://semver.io/node/resolve)
# Recommend using semver ranges in a safe manner
if [ "$semver_range" == "null" ]; then
......
......@@ -35,6 +35,13 @@ testDangerousRangeGreaterThan() {
assertCapturedSuccess
}
testRangeWithSpace() {
compile "range-with-space"
assertCaptured "Requested node range: >= 0.8.x"
assertCaptured "Resolved node version: 0.10."
assertCapturedSuccess
}
testStableVersion() {
compile "stable-node"
assertNotCaptured "PRO TIP: Avoid using semver"
......
A fake README, to keep npm from polluting stderr.
\ No newline at end of file
{
"name": "node-buildpack-test-app",
"version": "0.0.1",
"description": "node buildpack integration test app",
"repository" : {
"type" : "git",
"url" : "http://github.com/example/example.git"
},
"engines": {
"node": ">= 0.8.x"
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment