Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
H
heroku-buildpack-nodejs
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
JIRA
JIRA
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Python-Dev
heroku-buildpack-nodejs
Commits
427bd1e7
Commit
427bd1e7
authored
Mar 11, 2013
by
Zeke Sikelianos
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #31 from heroku/update_default_versions
default to latest versions of node and npm
parents
faee7662
978ee28a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
13 deletions
+12
-13
compile
bin/compile
+10
-11
test
bin/test
+2
-2
No files found.
bin/compile
View file @
427bd1e7
...
@@ -60,15 +60,17 @@ function resolve_version() {
...
@@ -60,15 +60,17 @@ function resolve_version() {
requested_version
=
"
$2
"
requested_version
=
"
$2
"
default_version
=
"
$3
"
default_version
=
"
$3
"
args
=
""
for
version
in
$available_versions
;
do
args
=
"
${
args
}
-v
\"
${
version
}
\"
"
;
done
if
[
"
$2
"
==
""
]
;
then
if
[
"
$2
"
==
""
]
;
then
echo
$3
args
=
"
${
args
}
-r
\"
${
default_version
}
\"
"
;
else
else
args
=
""
args
=
"
${
args
}
-r
\"
${
requested_version
}
\"
"
;
for
version
in
$available_versions
;
do
args
=
"
${
args
}
-v
\"
${
version
}
\"
"
;
done
for
version
in
$requested_version
;
do
args
=
"
${
args
}
-r
\"
${
version
}
\"
"
;
done
evaluated_version
=
$(
eval
$bootstrap_node
/bin/node
$LP_DIR
/vendor/node-semver/bin/semver
${
args
}
||
echo
""
)
echo
"
$evaluated_version
"
|
tail
-n
1
fi
fi
evaluated_versions
=
$(
eval
$bootstrap_node
/bin/node
$LP_DIR
/vendor/node-semver/bin/semver
${
args
}
||
echo
""
)
echo
"
$evaluated_versions
"
|
tail
-n
1
}
}
function
package_engine_version
()
{
function
package_engine_version
()
{
...
@@ -107,8 +109,8 @@ declare -A engine_versions
...
@@ -107,8 +109,8 @@ declare -A engine_versions
declare
-A
engine_defaults
declare
-A
engine_defaults
declare
-A
engine_requests
declare
-A
engine_requests
engine_defaults[
"node"
]=
"0.
4.7
"
engine_defaults[
"node"
]=
"0.
10.x
"
engine_defaults[
"npm"
]=
"1.
0.106
"
engine_defaults[
"npm"
]=
"1.
2.x
"
engine_versions[
"node"
]=
$(
manifest_versions
"nodejs"
)
engine_versions[
"node"
]=
$(
manifest_versions
"nodejs"
)
engine_requests[
"node"
]=
$(
package_engine_version
"node"
)
engine_requests[
"node"
]=
$(
package_engine_version
"node"
)
...
@@ -124,9 +126,6 @@ if [ "${engine_requests["node"]}" == "" ]; then
...
@@ -124,9 +126,6 @@ if [ "${engine_requests["node"]}" == "" ]; then
echo
"WARNING: No version of Node.js specified in package.json, see:"
| indent
echo
"WARNING: No version of Node.js specified in package.json, see:"
| indent
echo
"https://devcenter.heroku.com/articles/nodejs-versions"
| indent
echo
"https://devcenter.heroku.com/articles/nodejs-versions"
| indent
echo
echo
echo
"WARNING: The default version of Node.js and npm on Heroku will begin"
| indent
echo
"tracking the latest stable release starting September 1, 2012."
| indent
echo
fi
fi
NODE_VERSION
=
$(
package_resolve_version
"node"
)
NODE_VERSION
=
$(
package_resolve_version
"node"
)
...
...
bin/test
View file @
427bd1e7
...
@@ -30,8 +30,8 @@ testPackageJsonWithVersion() {
...
@@ -30,8 +30,8 @@ testPackageJsonWithVersion() {
testPackageJsonWithoutVersion
()
{
testPackageJsonWithoutVersion
()
{
compile
"package-json-noversion"
compile
"package-json-noversion"
assertCaptured
"WARNING: No version of Node.js specified"
assertCaptured
"WARNING: No version of Node.js specified"
assertCaptured
"Using Node.js version: 0.
4.7
"
assertCaptured
"Using Node.js version: 0.
10
"
assertCaptured
"Using npm version: 1.
0.106
"
assertCaptured
"Using npm version: 1.
2
"
assertCapturedSuccess
assertCapturedSuccess
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment