Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
H
heroku-buildpack-nodejs
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
JIRA
JIRA
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Python-Dev
heroku-buildpack-nodejs
Commits
4cf68e4e
Unverified
Commit
4cf68e4e
authored
Oct 31, 2018
by
Jeremy Morrell
Committed by
GitHub
Oct 31, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update default version to new Node LTS version v10.x (#581)
* Update default version to new Node LTS version v10.x
parent
e4e16069
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
6 additions
and
6 deletions
+6
-6
binaries.sh
lib/binaries.sh
+1
-1
package.json
test/fixtures/ci-dependencies-yarn/package.json
+1
-1
package.json
test/fixtures/dependencies-yarn/package.json
+1
-1
package.json
test/fixtures/node-env-consistency/package.json
+1
-1
run
test/run
+2
-2
No files found.
lib/binaries.sh
View file @
4cf68e4e
...
@@ -27,7 +27,7 @@ install_yarn() {
...
@@ -27,7 +27,7 @@ install_yarn() {
}
}
install_nodejs
()
{
install_nodejs
()
{
local
version
=
${
1
:-
8
.x
}
local
version
=
${
1
:-
10
.x
}
local dir
=
"
${
2
:?
}
"
local dir
=
"
${
2
:?
}
"
echo
"Resolving node version
$version
..."
echo
"Resolving node version
$version
..."
...
...
test/fixtures/ci-dependencies-yarn/package.json
View file @
4cf68e4e
...
@@ -11,7 +11,7 @@
...
@@ -11,7 +11,7 @@
},
},
"license"
:
"MIT"
,
"license"
:
"MIT"
,
"engines"
:
{
"engines"
:
{
"yarn"
:
"1.
4.0
"
"yarn"
:
"1.
x
"
},
},
"devDependencies"
:
{
"devDependencies"
:
{
"lodash"
:
"^2.4.1"
"lodash"
:
"^2.4.1"
...
...
test/fixtures/dependencies-yarn/package.json
View file @
4cf68e4e
...
@@ -11,7 +11,7 @@
...
@@ -11,7 +11,7 @@
},
},
"license"
:
"MIT"
,
"license"
:
"MIT"
,
"engines"
:
{
"engines"
:
{
"yarn"
:
"1.
4.0
"
"yarn"
:
"1.
x
"
},
},
"devDependencies"
:
{
"devDependencies"
:
{
"lodash"
:
"^2.4.1"
"lodash"
:
"^2.4.1"
...
...
test/fixtures/node-env-consistency/package.json
View file @
4cf68e4e
...
@@ -4,7 +4,7 @@
...
@@ -4,7 +4,7 @@
"main"
:
"index.js"
,
"main"
:
"index.js"
,
"license"
:
"MIT"
,
"license"
:
"MIT"
,
"engines"
:
{
"engines"
:
{
"npm"
:
"
5.5.1
"
"npm"
:
"
6.x
"
},
},
"scripts"
:
{
"scripts"
:
{
"heroku-prebuild"
:
"echo 'heroku-prebuild:' $NODE_ENV"
,
"heroku-prebuild"
:
"echo 'heroku-prebuild:' $NODE_ENV"
,
...
...
test/run
View file @
4cf68e4e
...
@@ -11,8 +11,8 @@
...
@@ -11,8 +11,8 @@
testNoVersion
()
{
testNoVersion
()
{
compile
"no-version"
compile
"no-version"
assertCaptured
"engines.node (package.json): unspecified"
assertCaptured
"engines.node (package.json): unspecified"
assertCaptured
"Resolving node version
8
.x"
assertCaptured
"Resolving node version
10
.x"
assertCaptured
"Downloading and installing node
8
."
assertCaptured
"Downloading and installing node
10
."
assertCapturedSuccess
assertCapturedSuccess
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment