Merge pull request #296 from heroku/fiznool-master

Fiznool master

CHANGELOG.md

 # Node.js Buildpack Changelog
 
+## Latest
+
+- Adds heroku-prebuild script
+- Adds heroku-postbuild script
+
 ## v88 (2016-2-23)
 
 - Retries all curl requests

bin/compile

@@ -118,12 +118,14 @@ header "Restoring cache"
 restore_cache | output "$LOG_FILE"
 
 build_dependencies() {
+  run_if_present 'heroku-prebuild'
   if $PREBUILD; then
     echo "Prebuild detected (node_modules already exists)"
     rebuild_node_modules "$BUILD_DIR"
   else
     install_node_modules "$BUILD_DIR"
   fi
+  run_if_present 'heroku-postbuild'
 }
 
 header "Building dependencies"

lib/dependencies.sh

+run_if_present() {
+  local script_name=${1:-}
+  local has_script=$(read_json "$BUILD_DIR/package.json" ".scripts[\"$script_name\"]")
+  if [ -n "$has_script" ]; then
+    echo "Running $script_name"
+    npm run "$script_name" --if-present
+  fi
+}
+
 install_node_modules() {
   local build_dir=${1:-}
 
   if [ -e $build_dir/package.json ]; then
     cd $build_dir
+
     echo "Pruning any extraneous modules"
     npm prune --unsafe-perm --userconfig $build_dir/.npmrc 2>&1
     if [ -e $build_dir/npm-shrinkwrap.json ]; then

test/fixtures/pre-post-build-scripts/README.md

+A fake README, to keep npm from polluting stderr.
\ No newline at end of file

test/fixtures/pre-post-build-scripts/package.json

+{
+  "name": "node-buildpack-test-app",
+  "version": "0.0.1",
+  "description": "node buildpack integration test app",
+  "repository" : {
+    "type" : "git",
+    "url" : "http://github.com/example/example.git"
+  },
+  "engines": {
+    "node": "~0.10.0"
+  },
+  "scripts" : {
+    "heroku-prebuild" : "echo heroku-prebuild hook message",
+    "heroku-postbuild" : "echo heroku-postbuild hook message"
+  }
+}

test/run

 #!/usr/bin/env bash
 # See README.md for info on running these tests.
 
+testPrePostBuildScripts() {
+  compile "pre-post-build-scripts"
+  assertCaptured "Running heroku-prebuild"
+  assertCaptured "echo heroku-prebuild hook message"
+  assertCaptured "Running heroku-postbuild"
+  assertCaptured "echo heroku-postbuild hook message"
+  assertCapturedSuccess
+
+  compile "stable-node"
+  assertNotCaptured "Running heroku-prebuild"
+  assertNotCaptured "Running heroku-postbuild"
+  assertCapturedSuccess
+}
+
 testWarningsOnFailure() {
   compile "many-warnings"
   assertCaptured "troubleshooting-node-deploys"