Commit 7fad531c authored by zeke's avatar zeke

I suck at git

parents c56b58c8 e7a4fff9
...@@ -87,3 +87,5 @@ The [ddollar/test](https://github.com/ddollar/buildpack-test) buildpack runs `bi ...@@ -87,3 +87,5 @@ The [ddollar/test](https://github.com/ddollar/buildpack-test) buildpack runs `bi
``` ```
heroku build -b ddollar/test # -b can also point to a local directory heroku build -b ddollar/test # -b can also point to a local directory
``` ```
For more info on testing, see [Best Practices for Testing Buildpacks](https://discussion.heroku.com/t/best-practices-for-testing-buildpacks/294) on the Heroku discussion forum.
...@@ -82,7 +82,7 @@ fi ...@@ -82,7 +82,7 @@ fi
) )
status "Caching node_modules directory for future builds" status "Caching node_modules directory for future builds"
rm -rf $cache_dir rm -rf $cache_dir/node_modules
mkdir -p $cache_dir mkdir -p $cache_dir
test -d $build_dir/node_modules && cp -r $build_dir/node_modules $cache_dir/ test -d $build_dir/node_modules && cp -r $build_dir/node_modules $cache_dir/
...@@ -119,5 +119,6 @@ echo "export PATH=\"\$HOME/vendor/node/bin:\$HOME/bin:\$HOME/node_modules/.bin:\ ...@@ -119,5 +119,6 @@ echo "export PATH=\"\$HOME/vendor/node/bin:\$HOME/bin:\$HOME/node_modules/.bin:\
--silent \ --silent \
--request POST \ --request POST \
--header "content-type: application/json" \ --header "content-type: application/json" \
https://nomnom.heroku.com/?request_id=$REQUEST_ID https://nomnom.heroku.com/?request_id=$REQUEST_ID \
> /dev/null
) & ) &
...@@ -121,36 +121,6 @@ testEnvfileImported() { ...@@ -121,36 +121,6 @@ testEnvfileImported() {
assertCaptured "Importing application config vars" assertCaptured "Importing application config vars"
} }
# Pending Tests
# testNodeBinariesAddedToPath() {
# }
# testNodeModulesRestoredFromCache() {
# }
# TODO: Figure out how to test stuff like script hooks
# when restoring node_modules from cache
# testScriptHooks() {
# compile "script-hooks"
# assertCaptured "trigger script hooks"
# assertCaptured "preinstall hook message"
# assertCapturedSuccess
# }
# testWithoutScriptHooks() {
# compile "no-script-hooks"
# assertNotCaptured "trigger script hooks"
# assertCapturedSuccess
# }
# testInvalidVersion() {
# compile "invalid-node-version"
# assertCapturedError 1 "not found among available versions"
# }
# Utils # Utils
pushd $(dirname 0) >/dev/null pushd $(dirname 0) >/dev/null
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment