Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
H
heroku-buildpack-nodejs
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
JIRA
JIRA
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Python-Dev
heroku-buildpack-nodejs
Commits
8469d24d
Unverified
Commit
8469d24d
authored
Dec 18, 2018
by
Jeremy Morrell
Committed by
GitHub
Dec 18, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add monitoring for binary installations (#591)
* Add monitoring for binary installations
parent
756ef0e3
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
3 deletions
+7
-3
compile
bin/compile
+3
-3
run
test/run
+4
-0
No files found.
bin/compile
View file @
8469d24d
...
@@ -122,8 +122,8 @@ install_bins() {
...
@@ -122,8 +122,8 @@ install_bins() {
mcount
"version.iojs.
$node_version
"
mcount
"version.iojs.
$node_version
"
else
else
warn_node_engine
"
$node_engine
"
warn_node_engine
"
$node_engine
"
install_nodejs
"
$node_engine
"
"
$BUILD_DIR
/.heroku/node"
monitor
"install-node-binary"
install_nodejs
"
$node_engine
"
"
$BUILD_DIR
/.heroku/node"
install_npm
"
$npm_engine
"
"
$BUILD_DIR
/.heroku/node"
$NPM_LOCK
monitor
"install-npm-binary"
install_npm
"
$npm_engine
"
"
$BUILD_DIR
/.heroku/node"
$NPM_LOCK
local
node_version
=
"
$(
node
--version
)
"
local
node_version
=
"
$(
node
--version
)
"
mcount
"version.node.
$node_version
"
mcount
"version.node.
$node_version
"
fi
fi
...
@@ -132,7 +132,7 @@ install_bins() {
...
@@ -132,7 +132,7 @@ install_bins() {
# has specified a version of yarn under "engines". We'll still
# has specified a version of yarn under "engines". We'll still
# only install using yarn if there is a yarn.lock file
# only install using yarn if there is a yarn.lock file
if
$YARN
||
[
-n
"
$yarn_engine
"
]
;
then
if
$YARN
||
[
-n
"
$yarn_engine
"
]
;
then
install_yarn
"
$BUILD_DIR
/.heroku/yarn"
"
$yarn_engine
"
monitor
"install-yarn-binary"
install_yarn
"
$BUILD_DIR
/.heroku/yarn"
"
$yarn_engine
"
fi
fi
if
$YARN
;
then
if
$YARN
;
then
...
...
test/run
View file @
8469d24d
...
@@ -1008,6 +1008,8 @@ testMemoryMetrics() {
...
@@ -1008,6 +1008,8 @@ testMemoryMetrics() {
echo
"
$metrics_log
"
>
$env_dir
/BUILDPACK_LOG_FILE
echo
"
$metrics_log
"
>
$env_dir
/BUILDPACK_LOG_FILE
compile
"pre-post-build-scripts"
"
$(
mktmpdir
)
"
$env_dir
compile
"pre-post-build-scripts"
"
$(
mktmpdir
)
"
$env_dir
assertFileContains
"measure#buildpack.nodejs.exec.install-node-binary.time="
$metrics_log
assertFileContains
"measure#buildpack.nodejs.exec.install-npm-binary.time="
$metrics_log
assertFileContains
"measure#buildpack.nodejs.exec.heroku-prebuild.time="
$metrics_log
assertFileContains
"measure#buildpack.nodejs.exec.heroku-prebuild.time="
$metrics_log
assertFileContains
"measure#buildpack.nodejs.exec.heroku-prebuild.memory="
$metrics_log
assertFileContains
"measure#buildpack.nodejs.exec.heroku-prebuild.memory="
$metrics_log
assertFileContains
"measure#buildpack.nodejs.exec.npm-install.time="
$metrics_log
assertFileContains
"measure#buildpack.nodejs.exec.npm-install.time="
$metrics_log
...
@@ -1018,6 +1020,8 @@ testMemoryMetrics() {
...
@@ -1018,6 +1020,8 @@ testMemoryMetrics() {
# erase the metrics log
# erase the metrics log
echo
""
>
$metrics_log
echo
""
>
$metrics_log
compile
"yarn"
"
$(
mktmpdir
)
"
$env_dir
compile
"yarn"
"
$(
mktmpdir
)
"
$env_dir
assertFileContains
"measure#buildpack.nodejs.exec.install-node-binary.time="
$metrics_log
assertFileContains
"measure#buildpack.nodejs.exec.install-yarn-binary.time="
$metrics_log
assertFileContains
"measure#buildpack.nodejs.exec.yarn-install.memory="
"
$metrics_log
"
assertFileContains
"measure#buildpack.nodejs.exec.yarn-install.memory="
"
$metrics_log
"
assertFileContains
"measure#buildpack.nodejs.exec.yarn-install.time="
"
$metrics_log
"
assertFileContains
"measure#buildpack.nodejs.exec.yarn-install.time="
"
$metrics_log
"
# this fixture does not have pre or post-build scripts
# this fixture does not have pre or post-build scripts
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment