Commit 8c67d739 authored by zeke's avatar zeke

always use https

parent e6703624
...@@ -9,8 +9,8 @@ How it Works ...@@ -9,8 +9,8 @@ How it Works
Here's an overview of what this buildpack does: Here's an overview of what this buildpack does:
- Uses the [semver.io](http://semver.io) webservice to find the latest version of node that satisfies the [engines.node semver range](https://npmjs.org/doc/json.html#engines) in your package.json. - Uses the [semver.io](https://semver.io) webservice to find the latest version of node that satisfies the [engines.node semver range](https://npmjs.org/doc/json.html#engines) in your package.json.
- Allows any recent version of node to be used, including [pre-release versions](http://semver.io/node.json). - Allows any recent version of node to be used, including [pre-release versions](https://semver.io/node.json).
- Uses an [S3 caching proxy](https://github.com/heroku/s3pository#readme) of nodejs.org for faster downloads of the node binary. - Uses an [S3 caching proxy](https://github.com/heroku/s3pository#readme) of nodejs.org for faster downloads of the node binary.
- Discourages use of dangerous semver ranges like `*` and `>0.10`. - Discourages use of dangerous semver ranges like `*` and `>0.10`.
- Uses the version of `npm` that comes bundled with `node`. - Uses the version of `npm` that comes bundled with `node`.
......
...@@ -19,7 +19,7 @@ trap cat_npm_debug_log ERR ...@@ -19,7 +19,7 @@ trap cat_npm_debug_log ERR
semver_range=$(cat $build_dir/package.json | $bp_dir/vendor/jq -r .engines.node) semver_range=$(cat $build_dir/package.json | $bp_dir/vendor/jq -r .engines.node)
# Resolve node version using semver.io # Resolve node version using semver.io
node_version=$(curl --silent --get --data-urlencode "range=${semver_range}" http://semver.io/node/resolve) node_version=$(curl --silent --get --data-urlencode "range=${semver_range}" https://semver.io/node/resolve)
# Recommend using semver ranges in a safe manner # Recommend using semver ranges in a safe manner
if [ "$semver_range" == "null" ]; then if [ "$semver_range" == "null" ]; then
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment