Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
H
heroku-buildpack-nodejs
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
JIRA
JIRA
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Python-Dev
heroku-buildpack-nodejs
Commits
b2e292c6
Unverified
Commit
b2e292c6
authored
Nov 28, 2018
by
Jeremy Morrell
Committed by
GitHub
Nov 28, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add warning for flatmap-stream 404 failure (#590)
Add warning for flatmap-stream 404 failure
parent
c38e2af1
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
48 additions
and
1 deletion
+48
-1
failure.sh
lib/failure.sh
+14
-1
package-lock.json
test/fixtures/flatmap-stream/package-lock.json
+12
-0
package.json
test/fixtures/flatmap-stream/package.json
+15
-0
run
test/run
+7
-0
No files found.
lib/failure.sh
View file @
b2e292c6
...
@@ -365,8 +365,21 @@ log_other_failures() {
...
@@ -365,8 +365,21 @@ log_other_failures() {
return
0
return
0
fi
fi
if
grep
-i
-e
"npm ERR! code E404"
-e
"error An unexpected error occurred: .* Request failed
\"
404 Not Found
\"
"
"
$log_file
"
;
then
if
grep
-
q
i
-e
"npm ERR! code E404"
-e
"error An unexpected error occurred: .* Request failed
\"
404 Not Found
\"
"
"
$log_file
"
;
then
mcount
"failures.module-404"
mcount
"failures.module-404"
if
grep
-qi
"flatmap-stream"
"
$log_file
"
;
then
mcount
"flatmap-stream-404"
warn
"The flatmap-stream module has been removed from the npm registry
On November 26th, npm was notified of a malicious package that had made its
way into event-stream, a popular npm package. After triaging the malware,
npm responded by removing flatmap-stream and event-stream@3.3.6 from the Registry
and taking ownership of the event-stream package to prevent further abuse.
"
https://kb.heroku.com/4OM7X18J/why-am-i-seeing-npm-404-errors-for-event-stream-flatmap-stream-in-my-build-logs
exit
1
fi
return
0
return
0
fi
fi
...
...
test/fixtures/flatmap-stream/package-lock.json
0 → 100644
View file @
b2e292c6
{
"name"
:
"flatmap-stream"
,
"version"
:
"1.0.0"
,
"lockfileVersion"
:
1
,
"dependencies"
:
{
"flatmap-stream"
:
{
"version"
:
"0.1.1"
,
"resolved"
:
"https://registry.npmjs.org/flatmap-stream/-/flatmap-stream-0.1.1.tgz"
,
"integrity"
:
"sha1-mDxroZk7WOroWZmKpof/6I34TBc="
}
}
}
\ No newline at end of file
test/fixtures/flatmap-stream/package.json
0 → 100644
View file @
b2e292c6
{
"name"
:
"flatmap-stream"
,
"version"
:
"1.0.0"
,
"description"
:
""
,
"main"
:
"index.js"
,
"scripts"
:
{
"test"
:
"echo
\"
Error: no test specified
\"
&& exit 1"
},
"keywords"
:
[],
"author"
:
""
,
"license"
:
"ISC"
,
"dependencies"
:
{
"flatmap-stream"
:
"0.1.1"
}
}
\ No newline at end of file
test/run
View file @
b2e292c6
...
@@ -8,6 +8,13 @@
...
@@ -8,6 +8,13 @@
# assertCapturedError
# assertCapturedError
#}
#}
testFlatmapStream
()
{
compile
"flatmap-stream"
assertCaptured
"flatmap-stream module has been removed from the npm registry"
assertCaptured
"why-am-i-seeing-npm-404-errors"
assertCapturedError
}
testBuildScriptBehavior
()
{
testBuildScriptBehavior
()
{
# opt in to new build script behavior
# opt in to new build script behavior
cache
=
$(
mktmpdir
)
cache
=
$(
mktmpdir
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment