Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
H
heroku-buildpack-nodejs
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
JIRA
JIRA
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Python-Dev
heroku-buildpack-nodejs
Commits
c09c3f83
Commit
c09c3f83
authored
Mar 27, 2012
by
David Dollar
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
add a warning of no version of node.js specified in package.json
parent
85170d5f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
0 deletions
+11
-0
compile
bin/compile
+9
-0
test
bin/test
+2
-0
No files found.
bin/compile
View file @
c09c3f83
...
...
@@ -116,6 +116,15 @@ engine_versions["npm"]=$(manifest_versions "npm")
engine_requests[
"npm"
]=
$(
package_engine_version
"npm"
)
echo
"-----> Resolving engine versions"
# add a warning if no version of node specified
if
[
"
${
engine_requests
[
"node"
]
}
"
==
""
]
;
then
echo
echo
"WARNING: No version of Node.js specified in package.json, see:"
| indent
echo
"https://devcenter.heroku.com/articles/nodejs-versions"
| indent
echo
fi
NODE_VERSION
=
$(
package_resolve_version
"node"
)
echo
"Using Node.js version:
${
NODE_VERSION
}
"
| indent
...
...
bin/test
View file @
c09c3f83
...
...
@@ -21,6 +21,7 @@ testDetectWithoutPackageJson() {
testPackageJsonWithVersion
()
{
compile
"package-json-version"
assertNotCaptured
"WARNING: No version of Node.js specified"
assertCaptured
"Using Node.js version: 0.6.11"
assertCaptured
"Using npm version: 1.1.9"
assertCapturedSuccess
...
...
@@ -28,6 +29,7 @@ testPackageJsonWithVersion() {
testPackageJsonWithoutVersion
()
{
compile
"package-json-noversion"
assertCaptured
"WARNING: No version of Node.js specified"
assertCaptured
"Using Node.js version: 0.4.7"
assertCaptured
"Using npm version: 1.0.106"
assertCapturedSuccess
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment