Commit c764e7ae authored by Hunter Loftis's avatar Hunter Loftis

update warning text for devDeps

parent 1d65a9b7
...@@ -99,11 +99,11 @@ warn_angular_resolution() { ...@@ -99,11 +99,11 @@ warn_angular_resolution() {
warn_missing_devdeps() { warn_missing_devdeps() {
local log_file="$1" local log_file="$1"
if grep -qi 'cannot find module' "$log_file"; then if grep -qi 'cannot find module' "$log_file"; then
warning "A module may be missing from package.json" "https://devcenter.heroku.com/articles/troubleshooting-node-deploys#ensure-you-aren-t-relying-on-untracked-dependencies" warning "A module may be missing from 'dependencies' in package.json" "https://devcenter.heroku.com/articles/troubleshooting-node-deploys#ensure-you-aren-t-relying-on-untracked-dependencies"
if [ "$NPM_CONFIG_PRODUCTION" == "true" ]; then if [ "$NPM_CONFIG_PRODUCTION" == "true" ]; then
local devDeps=$(read_json "$BUILD_DIR/package.json" ".devDependencies") local devDeps=$(read_json "$BUILD_DIR/package.json" ".devDependencies")
if [ "$devDeps" != "" ]; then if [ "$devDeps" != "" ]; then
warning "A module may be specified in devDependencies instead of dependencies" "https://devcenter.heroku.com/articles/nodejs-support#devdependencies" warning "This module may be specified in 'devDependencies' instead of 'dependencies'" "https://devcenter.heroku.com/articles/nodejs-support#devdependencies"
fi fi
fi fi
fi fi
......
...@@ -31,15 +31,15 @@ testWarnNoStart() { ...@@ -31,15 +31,15 @@ testWarnNoStart() {
testWarnDevDeps() { testWarnDevDeps() {
compile "missing-devdeps-1" compile "missing-devdeps-1"
assertCaptured "A module may be missing" assertCaptured "A module may be missing"
assertNotCaptured "A module may be specified" assertNotCaptured "This module may be specified"
assertCapturedError assertCapturedError
compile "missing-devdeps-2" compile "missing-devdeps-2"
assertCaptured "A module may be missing" assertCaptured "A module may be missing"
assertCaptured "A module may be specified" assertCaptured "This module may be specified"
assertCapturedError assertCapturedError
compile "failing-build" compile "failing-build"
assertNotCaptured "A module may be missing" assertNotCaptured "A module may be missing"
assertNotCaptured "A module may be specified" assertNotCaptured "This module may be specified"
assertCapturedError assertCapturedError
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment