Merge pull request #147 from heroku/yoga-optional-deps

test for NPM_CONFIG_OPTIONAL and debug output for all npm config vars

bin/compile

@@ -80,7 +80,7 @@ info "node_modules cached: $modules_cached"
 
 echo ""
 
-info "NPM_CONFIG_PRODUCTION=$NPM_CONFIG_PRODUCTION"
+printenv | grep NPM_CONFIG | indent
 info "DISABLE_BUILD_CACHE=$DISABLE_BUILD_CACHE"
 
 source $bp_dir/bin/warnings.sh

bin/test

@@ -188,6 +188,32 @@ testDevDependencies() {
   assertCapturedSuccess
 }
 
+testOptionalDependencies() {
+  env_dir=$(mktmpdir)
+  #echo "true" > $env_dir/NPM_CONFIG_OPTIONAL
+  compile "optional-dependencies" "$(mktmpdir)" $env_dir
+  assertNotCaptured "NPM_CONFIG_OPTIONAL"
+  assertCaptured "less"
+  assertCaptured "mime"
+  assertCaptured "mkdirp"
+  assertCaptured "clean-css"
+  assertCaptured "request"
+  assertCapturedSuccess
+}
+
+testNoOptionalDependencies() {
+  env_dir=$(mktmpdir)
+  echo "false" > $env_dir/NPM_CONFIG_OPTIONAL
+  compile "optional-dependencies" "$(mktmpdir)" $env_dir
+  assertCaptured "NPM_CONFIG_OPTIONAL=false"
+  assertCaptured "less"
+  assertNotCaptured "mime"
+  assertNotCaptured "mkdirp"
+  assertNotCaptured "clean-css"
+  assertNotCaptured "request"
+  assertCapturedSuccess
+}
+
 testDisableCache() {
   cache=$(mktmpdir)
   env_dir=$(mktmpdir)

test/optional-dependencies/README.md

+A fake README, to keep npm from polluting stderr.
\ No newline at end of file

test/optional-dependencies/package.json

+{
+  "name": "node-buildpack-test-app",
+  "version": "0.0.1",
+  "description": "node buildpack integration test app",
+  "repository" : {
+    "type" : "git",
+    "url" : "http://github.com/example/example.git"
+  },
+  "dependencies": {
+    "less": "1.7.0"
+  },
+  "engines": {
+    "node": "0.10.x"
+  },
+  "scripts": {
+    "start": "node foo.js"
+  }
+}