Skip to content

H
heroku-buildpack-nodejs
Commit eaca7485 authored by Robin Richtsfeld's avatar Robin Richtsfeld Committed by Jeremy Morrell
Browse files
Options

Fix some Bash issues (#505)

parent 778ad489
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 3 deletions
lib/binaries.sh
View file @ eaca7485
...@@ -28,7 +28,7 @@ install_yarn() { ...@@ -28,7 +28,7 @@ install_yarn() {
install_nodejs() { install_nodejs() {
local version=${1:-8.x} local version=${1:-8.x}
local dir="$2" local dir="${2:?}"
echo "Resolving node version $version..." echo "Resolving node version $version..."
if ! read number url < <(curl --silent --get --retry 5 --retry-max-time 15 --data-urlencode "range=$version" "https://nodebin.herokai.com/v1/node/$platform/latest.txt"); then if ! read number url < <(curl --silent --get --retry 5 --retry-max-time 15 --data-urlencode "range=$version" "https://nodebin.herokai.com/v1/node/$platform/latest.txt"); then
...@@ -41,7 +41,7 @@ install_nodejs() { ...@@ -41,7 +41,7 @@ install_nodejs() {
echo "Unable to download node: $code" && false echo "Unable to download node: $code" && false
fi fi
tar xzf /tmp/node.tar.gz -C /tmp tar xzf /tmp/node.tar.gz -C /tmp
rm -rf $dir/* rm -rf "$dir"/*
mv /tmp/node-v$number-$os-$cpu/* $dir mv /tmp/node-v$number-$os-$cpu/* $dir
chmod +x $dir/bin/* chmod +x $dir/bin/*
} }
......
test/utils
View file @ eaca7485
...@@ -36,7 +36,7 @@ capture() ...@@ -36,7 +36,7 @@ capture()
LAST_COMMAND="$@" LAST_COMMAND="$@"
$@ >${STD_OUT} 2>${STD_ERR} "$@" >${STD_OUT} 2>${STD_ERR}
RETURN=$? RETURN=$?
rtrn=${RETURN} # deprecated rtrn=${RETURN} # deprecated
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment