Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
H
heroku-buildpack-nodejs
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
JIRA
JIRA
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Python-Dev
heroku-buildpack-nodejs
Commits
8206fcf2
Unverified
Commit
8206fcf2
authored
Mar 11, 2019
by
Jeremy Morrell
Committed by
GitHub
Mar 11, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add temporary warning about "run build" change (#636)
* Add temporary bright warning about breaking change
parent
827e960b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
9 deletions
+9
-9
compile
bin/compile
+9
-8
run
test/run
+0
-1
No files found.
bin/compile
View file @
8206fcf2
...
...
@@ -252,18 +252,12 @@ build_dependencies() {
mtime
"modules.time.cache.
$cache_status
"
"
${
start
}
"
if
$YARN
;
then
header
"Build"
else
# npm already prints a new line after the install
# without skipping the newline there's an awkward double line break
header_skip_newline
"Build"
fi
header
"Build"
run_build_script
"
$BUILD_DIR
"
log_build_scripts
"
$BUILD_DIR
"
}
header
"
Build
ing dependencies"
| output
"
$LOG_FILE
"
header
"
Install
ing dependencies"
| output
"
$LOG_FILE
"
build_dependencies | output
"
$LOG_FILE
"
cache_build
()
{
...
...
@@ -319,4 +313,11 @@ warn_no_start "$BUILD_DIR"
warn_unmet_dep
"
$LOG_FILE
"
warn_old_npm_lockfile
$NPM_LOCK
bright_header
"Change to Node.js build process"
echo
" Heroku has begun executing the
\"
build
\"
script defined in package.json"
echo
" during Node.js builds."
echo
""
echo
" Read more: https://devcenter.heroku.com/changelog-items/1573"
echo
""
log_build_data
>>
"
$BUILDPACK_LOG_FILE
"
test/run
View file @
8206fcf2
...
...
@@ -600,7 +600,6 @@ testNpmVersionSpecific() {
testFailingBuild
()
{
compile
"failing-build"
assertCaptured
"Building dependencies"
assertCaptured
"Build failed"
assertCaptured
"We're sorry this build is failing"
assertNotCaptured
"Checking startup method"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment