Unverified Commit 8206fcf2 authored by Jeremy Morrell's avatar Jeremy Morrell Committed by GitHub

Add temporary warning about "run build" change (#636)

* Add temporary bright warning about breaking change
parent 827e960b
...@@ -252,18 +252,12 @@ build_dependencies() { ...@@ -252,18 +252,12 @@ build_dependencies() {
mtime "modules.time.cache.$cache_status" "${start}" mtime "modules.time.cache.$cache_status" "${start}"
if $YARN; then header "Build"
header "Build"
else
# npm already prints a new line after the install
# without skipping the newline there's an awkward double line break
header_skip_newline "Build"
fi
run_build_script "$BUILD_DIR" run_build_script "$BUILD_DIR"
log_build_scripts "$BUILD_DIR" log_build_scripts "$BUILD_DIR"
} }
header "Building dependencies" | output "$LOG_FILE" header "Installing dependencies" | output "$LOG_FILE"
build_dependencies | output "$LOG_FILE" build_dependencies | output "$LOG_FILE"
cache_build() { cache_build() {
...@@ -319,4 +313,11 @@ warn_no_start "$BUILD_DIR" ...@@ -319,4 +313,11 @@ warn_no_start "$BUILD_DIR"
warn_unmet_dep "$LOG_FILE" warn_unmet_dep "$LOG_FILE"
warn_old_npm_lockfile $NPM_LOCK warn_old_npm_lockfile $NPM_LOCK
bright_header "Change to Node.js build process"
echo " Heroku has begun executing the \"build\" script defined in package.json"
echo " during Node.js builds."
echo ""
echo " Read more: https://devcenter.heroku.com/changelog-items/1573"
echo ""
log_build_data >> "$BUILDPACK_LOG_FILE" log_build_data >> "$BUILDPACK_LOG_FILE"
...@@ -600,7 +600,6 @@ testNpmVersionSpecific() { ...@@ -600,7 +600,6 @@ testNpmVersionSpecific() {
testFailingBuild() { testFailingBuild() {
compile "failing-build" compile "failing-build"
assertCaptured "Building dependencies"
assertCaptured "Build failed" assertCaptured "Build failed"
assertCaptured "We're sorry this build is failing" assertCaptured "We're sorry this build is failing"
assertNotCaptured "Checking startup method" assertNotCaptured "Checking startup method"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment